Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

alicelovescake
Copy link
Member

@alicelovescake alicelovescake commented Mar 22, 2024

Backport of #41577

See that PR for details.

Notes: Added a new instance property navigationHistory on webContents API with navigationHistory.getEntryAtIndex method, enabling applications to retrieve the URL and title of any navigation entry within the browsing history.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 22, 2024
@trop trop bot added 29-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Mar 22, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 22, 2024
@alicelovescake alicelovescake changed the title feat: add navigationHistory.getEntryAtIndex(int index) method (#41577) feat: add navigationHistory.getEntryAtIndex(int index) method Mar 22, 2024
@alicelovescake alicelovescake marked this pull request as ready for review March 22, 2024 01:55
@alicelovescake
Copy link
Member Author

@MarshallOfSound @codebytere Trop doesn't tag reviewers for manual back ports so wanted to check if one of you can approve and help me merge this before the patch release tmr! Thanks in advance!

@deepak1556
Copy link
Member

Same here, please update the tests with changes from #41705. Thanks!

@jkleinsc jkleinsc merged commit 97eee46 into electron:29-x-y Apr 4, 2024
@release-clerk
Copy link

release-clerk bot commented Apr 4, 2024

No Release Notes

@alicelovescake alicelovescake deleted the manual-bp/alicelovescake/pr/41577/branch/29-x-y branch April 8, 2024 18:24
@trop trop bot requested a review from a team April 12, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.