Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add MAS build #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 14, 2015
Merged

Add MAS build #2920

merged 11 commits into from
Oct 14, 2015

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Sep 28, 2015

This PR adds a new MAS build which removes usages of private API calls of OS X and can be published to Mac App Store.

  • Disable auto updater
  • Disable crash reporter
  • Remove private API calls in libchromiumcontent
  • Verify it can be published to Mac App Store
  • Add a guide on using MAS build

Fixes #249.

@lipis
Copy link

lipis commented Sep 28, 2015

💯

@YurySolovyov
Copy link
Contributor

Shouldn't such build be a default one for mac?

@zcbenz
Copy link
Contributor Author

zcbenz commented Sep 28, 2015

Shouldn't such build be a default one for mac?

To be compatible with Mac App Store we have to disable some important features, I'll give a list of the features not available in MAS build as a part of this PR.

@fscherwi
Copy link
Contributor

👍

2 similar comments
@hankbao
Copy link
Contributor

hankbao commented Sep 29, 2015

👍

@rhysd
Copy link
Contributor

rhysd commented Sep 30, 2015

👍

@behrangsa behrangsa mentioned this pull request Oct 8, 2015
Closed
@zcbenz
Copy link
Contributor Author

zcbenz commented Oct 14, 2015

I have successfully uploaded the MAS build to iTunes Connect and passed Apple's private APIs usage check, but currently we are in the middle of upgrading our OS X build machines and I'm not able to provide a public build for now.

I'm merging this branch since the mas build doesn't affect our normal build, a public build and guides on uploading to Mac App Store will be provided in other pull requests.

screen shot 2015-10-14 at 12 00 24 pm

@hankbao
Copy link
Contributor

hankbao commented Oct 14, 2015

👍 Cool.

zcbenz added a commit that referenced this pull request Oct 14, 2015
@zcbenz
Merge pull request #2920 from atom/mas
eb344f3 
Add MAS build
@zcbenz zcbenz merged commit eb344f3 into master Oct 14, 2015
@zcbenz zcbenz deleted the mas branch October 14, 2015 04:34
@joshaber
Copy link
Contributor

🤘

@callumlocke
Copy link

👏

@herrmannplatz
Copy link
Contributor

💯

@kevinsawicki
Copy link
Contributor

👍 This is so awesome

@imskull
Copy link

imskull commented Oct 15, 2015

👍

@kamesh-a
Copy link

👍

@lipis
Copy link

lipis commented Oct 16, 2015

Do we have the public builds for MAS somewhere?! Can't find them..

@kevinmartin
Copy link
Contributor

a public build and guides on uploading to Mac App Store will be provided in other pull requests.

@behrangsa
Copy link

💯

@lipis
Copy link

lipis commented Oct 16, 2015

#3108

@engelgabriel engelgabriel mentioned this pull request Feb 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.