Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 26, 2021

Backport of #26889

See that PR for details.

Notes: Changed the default value of worldSafeExecuteJavaScript to be true.

@trop trop bot requested a review from MarshallOfSound January 26, 2021 22:24
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 26, 2021
@trop trop bot added 12-x-y backport This is a backport PR backport/requested 🗳 semver/major incompatible API changes labels Jan 26, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 26, 2021
@ckerr
Copy link
Member

ckerr commented Jan 26, 2021

Breadcrumb for any future travelers who follow this link (e.g. through the release notes) looking for information:

https://github.com/electron/electron/blob/master/docs/breaking-changes.md#planned-breaking-api-changes-120

@VerteDinde
Copy link
Member

Release WG approved this PR, but we need to wait to merge this until after a test in master has been fixed: #27525 We'll merge after this PR has been merged.

@codebytere
Copy link
Member

@VerteDinde this should be good now - pushed the fix to it!

@MarshallOfSound MarshallOfSound merged commit 28fa60f into 12-x-y Jan 29, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 29, 2021

Release Notes Persisted

Changed the default value of worldSafeExecuteJavaScript to be true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12-x-y backport/requested 🗳 backport This is a backport PR semver/major incompatible API changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.