feat: add serviceName to 'child-process-gone' / app.getAppMetrics() #25975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c49bbe7 to
c190e20
Compare
alexeykuzmin
approved these changes
Oct 16, 2020
codebytere
approved these changes
Oct 16, 2020
c190e20 to
e7046ea
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It turns out that the
nameadded in #24359 is localized. Add non-localizedserviceName.Checklist
npm testpassesRelease Notes
Notes: Added non-localized
serviceNameto'child-process-gone'/app.getAppMetrics().