feat: [net] add "credentials" option to net.request #25284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB. this change depends on the current master roll: #24984 |
deepak1556
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Api looks better now 👍
Also useSessionCookies was added for #8891 where users where only concerned with whether the cookies are completely handled by the store or not. So this change is reasonable for that too.
|
@MarshallOfSound this is not semver/major because it doesn't break old behavior. it'll be semver/major when we remove the old one. |
515d3c9 to
8fd33c0
Compare
|
The API WG approved this at the Sept 21, 2020 meeting. |
jkleinsc
requested changes
Sep 24, 2020
|
@jkleinsc ping |
jkleinsc
approved these changes
Sep 28, 2020
|
Release Notes Persisted
|
6 tasks
zeeker999
pushed a commit
to zeeker999/electron
that referenced
this pull request
Mar 13, 2021
* feat: [net] add "credentials" option to net.request * remove debugging log * add tests
zeeker999
pushed a commit
to zeeker999/electron
that referenced
this pull request
Mar 13, 2021
* feat: [net] add "credentials" option to net.request * remove debugging log * add tests
zeeker999
pushed a commit
to zeeker999/electron
that referenced
this pull request
Apr 9, 2021
* feat: [net] add "credentials" option to net.request * remove debugging log * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds a new option to
net.request(), "credentials", which more closely matches the behavior offetch()than does "useSessionCookies".If "credentials" is specified it overrides "useSessionCookies", otherwise the default behavior remains unchanged.
Checklist
npm testpassesRelease Notes
Notes: Added a new "credentials" option for
net.request().