feat(extensions): add support for some chrome.management APIs #25098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
suggested changes
Aug 25, 2020
zcbenz
approved these changes
Sep 2, 2020
|
Release Notes Persisted
|
|
@zcbenz Could it be backported to 9-x-y? |
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I was unable to backport this PR to "10-x-y" cleanly; |
|
I was unable to backport this PR to "11-x-y" cleanly; |
|
@sentialx You have to manually backport the PR to 11/10/9 branches, and it would also require approval from @electron/wg-api to get merged. |
sentialx
added a commit
to sentialx/electron
that referenced
this pull request
Sep 6, 2020
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
6 tasks
sentialx
added a commit
to sentialx/electron
that referenced
this pull request
Sep 6, 2020
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
6 tasks
sentialx
added a commit
to sentialx/electron
that referenced
this pull request
Sep 6, 2020
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
6 tasks
sentialx
added a commit
to sentialx/electron
that referenced
this pull request
Sep 6, 2020
…on#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
zcbenz
pushed a commit
that referenced
this pull request
Sep 8, 2020
#25342) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
zcbenz
pushed a commit
that referenced
this pull request
Sep 8, 2020
#25345) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings
zcbenz
pushed a commit
that referenced
this pull request
Sep 8, 2020
* feat(extensions): add support for some chrome.management APIs (#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings * feat(extensions): add support for some chrome.management APIs (#25098) * fix: initialize management policy * fix(extensions): crash when using chrome.management * test: add tests * docs: add a note about chrome.management * fix: lint errors * fix: lint errors * fix: remove favicon_service include * fix: add missing management permission * docs: more supported apis * fix: extensions.md line endings * Update electron_extensions_api_client.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR implements missing
extensions::ManagementAPIDelegatewhich is being used bychrome.managementAPI and also fixes a crash when an extension is attempting to use the API.It doesn't implement all of the
chrome.managementfunctionalities, as they need to emit relevant events insessionor insession.extensions, so that developers could set their own behavior. I will probably do that in another PR.Could this be backported to 9-x-y?
Checklist
npm testpassesRelease Notes
Notes: Added support for some
chrome.managementAPIs.