feat: remove deprecated base::Value-based serialization #21560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
approved these changes
Dec 17, 2019
zcbenz
approved these changes
Dec 18, 2019
pull bot
pushed a commit
to kokizzu/electron
that referenced
this pull request
Dec 18, 2019
* feat: remove deprecated base::Value-based serialization * add note to breaking-changes
pull bot
pushed a commit
to kokizzu/electron
that referenced
this pull request
Dec 18, 2019
* feat: remove deprecated base::Value-based serialization * add note to breaking-changes
|
This has actually been merged (for twice) and the website is not updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This was included as a transitional measure when we moved IPC to using Structured Clone. The old behavior was deprecated in 8.x, and this removes it for 9.x.
Checklist
npm testpassesRelease Notes
Notes: Objects not serializable using Structured Clone will now cause an error to be thrown when attempting to send them across IPC.