Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Nov 29, 2019

Description of Change

Fixes building with enable_builtin_spellchecker = false introduced in #20692

Undefined symbols for architecture x86_64:
  "SpellcheckWordIterator::Initialize(SpellcheckCharAttribute const*, bool)", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
  "SpellcheckWordIterator::GetNextWord(std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >*, unsigned long*, unsigned long*)", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
      electron::api::SpellCheckClient::IsContraction(electron::api::SpellCheckClient::SpellCheckScope const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > >*) in atom_api_spell_check_client.o
  "SpellcheckWordIterator::SetText(unsigned short const*, unsigned long)", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
      electron::api::SpellCheckClient::IsContraction(electron::api::SpellCheckClient::SpellCheckScope const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > >*) in atom_api_spell_check_client.o
  "SpellcheckWordIterator::SpellcheckWordIterator()", referenced from:
      electron::api::SpellCheckClient::SpellCheckClient(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, v8::Isolate*, v8::Local<v8::Object>) in atom_api_spell_check_client.o
  "SpellcheckWordIterator::~SpellcheckWordIterator()", referenced from:
      electron::api::SpellCheckClient::~SpellCheckClient() in atom_api_spell_check_client.o
  "SpellcheckCharAttribute::SetDefaultLanguage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced from:
      electron::api::SpellCheckClient::SpellCheckClient(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, v8::Isolate*, v8::Local<v8::Object>) in atom_api_spell_check_client.o
  "SpellcheckCharAttribute::SpellcheckCharAttribute()", referenced from:
      electron::api::SpellCheckClient::SpellCheckClient(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, v8::Isolate*, v8::Local<v8::Object>) in atom_api_spell_check_client.o
  "SpellcheckCharAttribute::~SpellcheckCharAttribute()", referenced from:
      electron::api::SpellCheckClient::~SpellCheckClient() in atom_api_spell_check_client.o
  "SpellcheckWordIterator::IsInitialized() const", referenced from:
      electron::api::SpellCheckClient::SpellCheckText() in atom_api_spell_check_client.o
      electron::api::SpellCheckClient::IsContraction(electron::api::SpellCheckClient::SpellCheckScope const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, std::__1::vector<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >, std::__1::allocator<std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > > >*) in atom_api_spell_check_client.o
ld: symbol(s) not found for architecture x86_64

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak self-assigned this Nov 29, 2019
@miniak miniak force-pushed the miniak/enable_builtin_spellchecker branch from 4caa9e0 to ed63c43 Compare November 29, 2019 12:42
@deepak1556 deepak1556 force-pushed the miniak/enable_builtin_spellchecker branch 2 times, most recently from 11d67a7 to d3d6ee0 Compare November 30, 2019 04:23
@miniak miniak force-pushed the miniak/enable_builtin_spellchecker branch from d3d6ee0 to 8d4f101 Compare November 30, 2019 10:49
@miniak miniak requested a review from deepak1556 November 30, 2019 10:50
@deepak1556 deepak1556 merged commit 03824ef into master Nov 30, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 30, 2019

No Release Notes

@deepak1556 deepak1556 deleted the miniak/enable_builtin_spellchecker branch November 30, 2019 22:18
@trop
Copy link
Contributor

trop bot commented Nov 30, 2019

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 30, 2019

@deepak1556 has manually backported this PR to "8-x-y", please check out #21341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.