Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: macOS removal fallback when moveItemToTrash fails #19700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2019
Merged

feat: macOS removal fallback when moveItemToTrash fails #19700

merged 3 commits into from
Aug 13, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 9, 2019 •
edited
Loading

Description of Change

Refs #4974.

Some macOS volumes may not support a Trash folder or it may be disabled, so these methods will report failure by returning NO or nil and an NSError with NSFeatureUnsupportedError.

This enables consumers to handle this by optionally passing a boolean deleteOnFail value to indicate whether or not the item should be unilaterally deleted if the NSFileManager fails to execute trashItemAtURL.

cc @miniak @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: Enable macOS users to fallback to item removal when when shell.moveItemToTrash fails.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 9, 2019
deepak1556
deepak1556 reviewed Aug 9, 2019
View reviewed changes
shell/common/platform_util.h Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 10, 2019
@codebytere codebytere requested a review from deepak1556 August 12, 2019 16:29
deepak1556
deepak1556 reviewed Aug 12, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with api change.

shell/common/api/atom_api_shell.cc Outdated Show resolved Hide resolved
@codebytere codebytere requested a review from deepak1556 August 13, 2019 18:25
@codebytere codebytere merged commit e1824c0 into master Aug 13, 2019
@codebytere codebytere deleted the improve-trashing branch August 13, 2019 19:31
@release-clerk
Copy link

release-clerk bot commented Aug 13, 2019

Release Notes Persisted

Enable macOS users to fallback to item removal when when shell.moveItemToTrash fails.

@codebytere codebytere mentioned this pull request Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@miniak miniak Awaiting requested review from miniak

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codebytere @deepak1556 @MarshallOfSound
Morty Proxy This is a proxified and sanitized view of the page, visit original site.