feat: add property to accessible BrowserWindow window title #19698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
@mshoho please use the PR template for description. |
miniak
approved these changes
Aug 9, 2019
miniak
requested changes
Aug 9, 2019
|
please use the correct PR template |
MarshallOfSound
requested changes
Aug 9, 2019
miniak
approved these changes
Aug 15, 2019
miniak
reviewed
Aug 16, 2019
|
@MarshallOfSound can you please review the current version? |
ckerr
approved these changes
Aug 27, 2019
codebytere
reviewed
Aug 27, 2019
codebytere
approved these changes
Aug 27, 2019
MarshallOfSound
approved these changes
Aug 27, 2019
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Sometimes it's necessary to convey more information about the window to the screen reader users only (simply putting everything to the window title might be unnecessarily noisy).
For example, Chromium uses that technique to tell the screen reader users that the window is in incognito mode (the incognito window looks differently and doesn't have «incognito» in the title, but for the blind users the screen reader will announce that it's incognito).
Chromium has GetAccessibleWindowTitle() method internally. This PR exposes a way to customize the accessible title via Electron API.
Checklist
npm testpassesRelease Notes
Notes: Added
win.accessibleTitle propertyto be able to augment the window title for the screen readers.