test: tsify session spec #19604
Merged
test: tsify session spec #19604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
The main specs fails with:
Unhandled exception in main spec runner: electron/spec-main/api-session-spec.ts(8,23): error TS7016: Could not find a declaration file for module 'send'. '/Users/distiller/project/src/electron/node_modules/send/index.js' implicitly has an 'any' type.
Try `npm install @types/send` if it exists or add a new declaration (.d.ts) file containing `declare module 'send';`
electron/spec-main/api-session-spec.ts(9,23): error TS2307: Cannot find module 'basic-auth'.
|
ah right, i |
|
It seems that the CI on master branch is failing and this PR is affected. |
zcbenz
approved these changes
Aug 6, 2019
0925ac3 to
d6b1ca9
Compare
d6b1ca9 to
b43f2ca
Compare
ckerr
reviewed
Aug 23, 2019
b43f2ca to
8977e27
Compare
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Also fix a few doc bugs I found along the way.
Checklist
npm testpassesRelease Notes
Notes: none