Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 90e338d

Browse filesBrowse files
authored
fix: run toast creation on background thread (#49106)
* fix: run toast creation on background thread notes: attempts to fix app freeze when triggering notifications and the COM server in WindowsShellExperienceHost hangs * fix: comments
1 parent 1b3fc9c commit 90e338d
Copy full SHA for 90e338d

File tree

Expand file treeCollapse file tree

4 files changed

+330
-66
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+330
-66
lines changed
Open diff view settings
Collapse file

‎shell/browser/notifications/notification.cc‎

Copy file name to clipboardExpand all lines: shell/browser/notifications/notification.cc
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ const bool debug_notifications =
1414
base::Environment::Create()->HasVar("ELECTRON_DEBUG_NOTIFICATIONS");
1515

1616
NotificationOptions::NotificationOptions() = default;
17+
NotificationOptions::NotificationOptions(const NotificationOptions&) = default;
18+
NotificationOptions& NotificationOptions::operator=(
19+
const NotificationOptions&) = default;
20+
NotificationOptions::NotificationOptions(NotificationOptions&&) = default;
21+
NotificationOptions& NotificationOptions::operator=(NotificationOptions&&) =
22+
default;
1723
NotificationOptions::~NotificationOptions() = default;
1824

1925
Notification::Notification(NotificationDelegate* delegate,
Collapse file

‎shell/browser/notifications/notification.h‎

Copy file name to clipboardExpand all lines: shell/browser/notifications/notification.h
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ struct NotificationOptions {
4343
std::u16string toast_xml;
4444

4545
NotificationOptions();
46+
NotificationOptions(const NotificationOptions&);
47+
NotificationOptions& operator=(const NotificationOptions&);
48+
NotificationOptions(NotificationOptions&&);
49+
NotificationOptions& operator=(NotificationOptions&&);
4650
~NotificationOptions();
4751
};
4852

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.