Clarify that Shield is required#5
Merged
Clarify that Shield is required#5
Conversation
See https://discuss.elastic.co/t/shield-is-off-but-cant-connect-with-transport-client/65650/1. It doesn't hurt to be specific, as new users might try to take the easy route and not enable Shield ... only to fail because Shield is required.
Contributor
|
For 2.x, Shield is fine, but I wonder if we shouldn't say something like "X-Pack Security (previously Shield)" on master. (This PR itself LGTM) 👍 |
nrichers
pushed a commit
that referenced
this pull request
Nov 11, 2016
Companion PR to #5 Note that as per recent product naming guideline changes, we don't use "X-Pack Security" (some X-Pack docs might still be incorrect). We now say "X-Pack security features." :-)
Contributor
Author
|
@nkvoll Thank you for reviewing! I created a separate PR against master to make a similar change for X-Pack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://discuss.elastic.co/t/shield-is-off-but-cant-connect-with-transport-client/65650/1. It doesn't hurt to be specific, as new users might try to take the easy route and not enable Shield ... only to fail because Shield is required.