Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Please consider the following formatting changes to #14891 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 2 commits into from
Closed

Please consider the following formatting changes to #14891 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b4524
GPU QA: quick fix for rejection histogram bug
ehellbar Dec 5, 2025
330f7c1
Please consider the following formatting changes
alibuild Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 1 Detectors/TPC/base/test/testTPCCalDet.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ BOOST_AUTO_TEST_CASE(CalDetStreamerTest)
o2::tpc::DeadChannelMapCreator creator{};
creator.init("https://alice-ccdb.cern.ch");
creator.loadIDCPadFlags(1731274461770);
creator.loadFEEConfig(1731274461770);
}

} // namespace o2::tpc
135 changes: 0 additions & 135 deletions 135 GPU/GPUTracking/qa/GPUQA.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,13 +542,6 @@ int32_t GPUQA::InitQACreateHistograms()
createHist(mT0[0], "tracks_t0", "tracks_t0", (maxTime + 1) / 10, 0, maxTime);
createHist(mT0[1], "tracks_t0_res", "tracks_t0_res", 1000, -100, 100);
createHist(mClXY, "clXY", "clXY", 1000, -250, 250, 1000, -250, 250); // TODO: Pass name only once

const int padCount = GPUTPCGeometry::NPads(GPUCA_ROW_COUNT - 1);
for (int32_t i = 0; i < 3; i++) {
snprintf(name, 2048, "clrej_%d", i);
createHist(mClRej[i], name, name, 2 * padCount, -padCount / 2 + 0.5f, padCount / 2 - 0.5f, GPUCA_ROW_COUNT, 0, GPUCA_ROW_COUNT - 1);
}
createHist(mClRejP, "clrejp", "clrejp", GPUCA_ROW_COUNT, 0, GPUCA_ROW_COUNT - 1);
}

if ((mQATasks & taskClusterCounts) && mConfig.clusterRejectionHistograms) {
Expand Down Expand Up @@ -1812,78 +1805,6 @@ void GPUQA::RunQA(bool matchOnly, const std::vector<o2::tpc::TrackTPC>* tracksEx

uint32_t nCl = clNative ? clNative->nClustersTotal : mTracking->GetProcessors()->tpcMerger.NMaxClusters();
mClusterCounts.nTotal += nCl;
if (mQATasks & taskClusterCounts) {
for (uint32_t iSector = 0; iSector < GPUCA_NSECTORS; iSector++) {
for (uint32_t iRow = 0; iRow < GPUCA_ROW_COUNT; iRow++) {
for (uint32_t iCl = 0; iCl < mTracking->mIOPtrs.clustersNative->nClusters[iSector][iRow]; iCl++) {
uint32_t i = mTracking->mIOPtrs.clustersNative->clusterOffset[iSector][iRow] + iCl;
int32_t attach = mTracking->mIOPtrs.mergedTrackHitAttachment[i];
const auto& r = checkClusterState<true>(attach, &mClusterCounts);

if (mcAvail) {
float totalWeight = 0, weight400 = 0, weight40 = 0;
for (int32_t j = 0; j < GetMCLabelNID(i); j++) {
const auto& label = GetMCLabel(i, j);
if (GetMCLabelID(label) >= 0) {
totalWeight += GetMCLabelWeight(label);
if (GetMCTrackObj(mMCParam, label).pt >= 0.4) {
weight400 += GetMCLabelWeight(label);
}
if (GetMCTrackObj(mMCParam, label).pt <= 0.04) {
weight40 += GetMCLabelWeight(label);
}
}
}
if (totalWeight > 0 && 10.f * weight400 >= totalWeight) {
if (!r.unattached && !r.protect && !r.physics) {
mClusterCounts.nFakeRemove400++;
int32_t totalFake = weight400 < 0.9f * totalWeight;
if (totalFake) {
mClusterCounts.nFullFakeRemove400++;
}
/*printf("Fake removal (%d): Hit %7d, attached %d lowPt %d looper %d tube200 %d highIncl %d tube %d bad %d recPt %7.2f recLabel %6d", totalFake, i, (int32_t) (mClusterParam[i].attached || mClusterParam[i].fakeAttached),
(int32_t) lowPt, (int32_t) ((attach & gputpcgmmergertypes::attachGoodLeg) == 0), (int32_t) ((attach & gputpcgmmergertypes::attachTube) && mev200),
(int32_t) ((attach & gputpcgmmergertypes::attachHighIncl) != 0), (int32_t) ((attach & gputpcgmmergertypes::attachTube) != 0), (int32_t) ((attach & gputpcgmmergertypes::attachGood) == 0),
fabsf(qpt) > 0 ? 1.f / qpt : 0.f, id);
for (int32_t j = 0;j < GetMCLabelNID(i);j++)
{
//if (GetMCLabelID(i, j) < 0) break;
printf(" - label%d %6d weight %5d", j, GetMCLabelID(i, j), (int32_t) GetMCLabelWeight(i, j));
if (GetMCLabelID(i, j) >= 0) printf(" - pt %7.2f", mMCParam[GetMCLabelID(i, j)].pt);
else printf(" ");
}
printf("\n");*/
}
mClusterCounts.nAbove400++;
}
if (totalWeight > 0 && weight40 >= 0.9 * totalWeight) {
mClusterCounts.nBelow40++;
if (r.protect || r.physics) {
mClusterCounts.nFakeProtect40++;
}
}
}

if (r.physics) {
mClusterCounts.nPhysics++;
}
if (r.protect) {
mClusterCounts.nProt++;
}
if (r.unattached) {
mClusterCounts.nUnattached++;
}
if (mTracking && mTracking->mIOPtrs.clustersNative) {
const auto& cl = mTracking->mIOPtrs.clustersNative->clustersLinear[i];
mClRej[0]->Fill(cl.getPad() - GPUTPCGeometry::NPads(iRow) / 2 + 0.5, iRow, 1.f);
if (!r.unattached && !r.protect) {
mClRej[1]->Fill(cl.getPad() - GPUTPCGeometry::NPads(iRow) / 2 + 0.5, iRow, 1.f);
}
}
}
}
}
}

// Process cluster count statistics
if ((mQATasks & taskClusterCounts) && mConfig.clusterRejectionHistograms) {
Expand Down Expand Up @@ -3022,62 +2943,6 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
if (mConfig.writeFileExt != "") {
mCClXY->Print(Form("%s/clustersXY.%s", mConfig.plotsDir.c_str(), mConfig.writeFileExt.c_str()));
}

if (mQATasks & taskClusterCounts) {
mClRej[2]->Divide(mClRej[1], mClRej[0]);

for (int32_t i = 0; i < 3; i++) {
if (tout && !mConfig.inputHistogramsOnly) {
mClRej[i]->Write();
}
mPClRej[i]->cd();
mClRej[i]->SetTitle(REJECTED_NAMES[i]);
mClRej[i]->SetOption("colz");
mClRej[i]->Draw();
mCClRej[i]->cd();
mCClRej[i]->Print(Form("%s/clustersRej%d%s.pdf", mConfig.plotsDir.c_str(), i, REJECTED_NAMES[i]));
if (mConfig.writeFileExt != "") {
mCClRej[i]->Print(Form("%s/clustersRej%d%s.%s", mConfig.plotsDir.c_str(), i, REJECTED_NAMES[i], mConfig.writeFileExt.c_str()));
}
}

mPClRejP->cd();
for (int32_t k = 0; k < ConfigNumInputs; k++) {
auto* tmp = mClRej[0];
if (GetHist(tmp, tin, k, nNewInput) == nullptr) {
continue;
}
TH1D* proj1 = tmp->ProjectionY(Form("clrejptmp1%d", k)); // TODO: Clean up names
proj1->SetDirectory(nullptr);
tmp = mClRej[1];
if (GetHist(tmp, tin, k, nNewInput) == nullptr) {
continue;
}
TH1D* proj2 = tmp->ProjectionY(Form("clrejptmp2%d", k));
proj2->SetDirectory(nullptr);

auto* e = mClRejP;
if (GetHist(e, tin, k, nNewInput) == nullptr) {
continue;
}
e->Divide(proj2, proj1);
if (tout && !mConfig.inputHistogramsOnly && k == 0) {
e->Write();
}
delete proj1;
delete proj2;
e->SetMinimum(-0.02);
e->SetMaximum(0.22);
e->SetTitle("Rejected Clusters");
e->GetXaxis()->SetTitle("Pad Row");
e->GetYaxis()->SetTitle("Rejected Clusters (fraction)");
e->Draw(k == 0 ? "" : "same");
}
mPClRejP->Print(Form("%s/clustersRejProjected.pdf", mConfig.plotsDir.c_str()));
if (mConfig.writeFileExt != "") {
mPClRejP->Print(Form("%s/clustersRejProjected.%s", mConfig.plotsDir.c_str(), mConfig.writeFileExt.c_str()));
}
}
}

if (tout && !mConfig.inputHistogramsOnly && mConfig.writeMCLabels) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.