From 0353965616357ac63cd8c9651f4af9fe30a75d1b Mon Sep 17 00:00:00 2001 From: EGOIST <0x142857@gmail.com> Date: Mon, 19 Apr 2021 12:44:01 +0800 Subject: [PATCH 1/5] chore: allow comma-dangle --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index ad99170..cd300d8 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,8 @@ "error", 5 ], - "import/order": "off" + "import/order": "off", + "comma-dangle": "off" } }, "build": { From 34276a0e6554e25bf07f3c1ed42f7094dbae2afb Mon Sep 17 00:00:00 2001 From: EGOIST <0x142857@gmail.com> Date: Mon, 19 Apr 2021 12:47:58 +0800 Subject: [PATCH 2/5] chore: allow to trigger release via commit message /release --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index dc9ff0a..4672295 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,6 +40,6 @@ jobs: # If the commit is tagged with a version (e.g. "v1.0.0"), # release the app after building - release: ${{ startsWith(github.ref, 'refs/tags/v') }} + release: ${{ startsWith(github.ref, 'refs/tags/v') || contains(github.event.head_commit.message, '/release') }} mac_certs: ${{ secrets.MAC_CERTS }} mac_certs_password: ${{ secrets.MAC_CERTS_PASSWORD }} From a845cfff84e6a45ca7d83a4383c74fe01e96bb35 Mon Sep 17 00:00:00 2001 From: EGOIST <0x142857@gmail.com> Date: Mon, 19 Apr 2021 12:50:52 +0800 Subject: [PATCH 3/5] chore: trigger workflow on push /release --- .github/workflows/release.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4672295..9059235 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -4,6 +4,8 @@ on: push: tags: - v** + branches: + - master jobs: release: From 4cd60b603e5021d6868860c03c33ca099e011ce7 Mon Sep 17 00:00:00 2001 From: EGOIST <0x142857@gmail.com> Date: Mon, 19 Apr 2021 12:59:48 +0800 Subject: [PATCH 4/5] chore: disable app signing apple developer program is a waste of money /release --- .github/workflows/release.yml | 5 ----- package.json | 1 - 2 files changed, 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9059235..695deeb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -32,9 +32,6 @@ jobs: - name: Build/release Electron app uses: samuelmeuli/action-electron-builder@v1 - env: - APPLEID: ${{ secrets.APPLEID }} - APPLEIDPASS: ${{ secrets.APPLEIDPASS }} with: # GitHub token, automatically provided to the action # (No need to define this secret in the repo settings) @@ -43,5 +40,3 @@ jobs: # If the commit is tagged with a version (e.g. "v1.0.0"), # release the app after building release: ${{ startsWith(github.ref, 'refs/tags/v') || contains(github.event.head_commit.message, '/release') }} - mac_certs: ${{ secrets.MAC_CERTS }} - mac_certs_password: ${{ secrets.MAC_CERTS_PASSWORD }} diff --git a/package.json b/package.json index cd300d8..2cc9f7d 100644 --- a/package.json +++ b/package.json @@ -67,7 +67,6 @@ "dmg": { "sign": false }, - "afterSign": "scripts/notarize.js", "mac": { "category": "public.app-category.developer-tools", "hardenedRuntime": true, From 791786035527b7cf8d5e8335cc5ec506fdd20e4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=82=AB=E3=83=AF=E3=83=AA=E3=83=9F=E4=BA=BA=E5=BD=A2?= Date: Mon, 19 Apr 2021 14:27:12 +0900 Subject: [PATCH 5/5] Update README.md (#153) brew cask install is disabled --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 18764c6..abc9736 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,7 @@ Use Ctrl+Shift+D (or Command+Shift+D on macOS) to toggle t ### Using Homebrew ``` -brew cask install devdocs +brew install --cask devdocs ``` ### Manual download