Francis x Jen changes for MSIAB#53
Merged
notthatjen merged 19 commits intomsiab_improvementseditmodelabs/editmode-react:msiab_improvementsfrom Jul 2, 2021
Merged
Francis x Jen changes for MSIAB#53notthatjen merged 19 commits intomsiab_improvementseditmodelabs/editmode-react:msiab_improvementsfrom
notthatjen merged 19 commits intomsiab_improvementseditmodelabs/editmode-react:msiab_improvementsfrom
Conversation
notthatjen
added a commit
that referenced
this pull request
Jul 6, 2021
* repalce referrer params with editmode-referrer header * Try contentOnly attr in chunkfieldvalue * Remove contentOnly * Add getChunk in collections * Add field attribut to chunk, add getChunk * Make projectId optional for getChunk * Fix getchunk, handle svg * putback inlinesvg * Use 2.0.1 editmode js to hide collection buttons * update svg checker * Try magic editor * remove async * Fix cpage break when collection has no response, fix add new collection * Transfer document call inside useEffect * Use released version of magic-editor * AUse latest version of magic-editor * Add watermark * Add index to chunk collection mapper * Redesign watermark, accept field parameter in useGetChunk * Add tag_list to collections add refs to watermark * Remove localhost magic editor url * Francis x Jen changes for MSIAB (#53) * caching editmode provider request * code cleanup * v3.1.31-canary.0 * v3.1.31-canary.8 * update script src * v3.1.31-canary.9 * _ * v3.1.31-canary.10 * adding lazy checks for caching * add new caching helpers * implement caching with expiry * set time to one hour * implementing add tags to new collection item * add tags to collection wrapper * Remove canary hardcoded version * Put magic editor unpkg url * ignore dist * npm ignore dist Co-authored-by: Francis Bulus <notchera@gmail.com> * Use template tag on collection placeholder * Fix useGetChunk * Apply useContext on useGetChunk * Fix issue with timecache * Remove replaceAll usage * Add defer attribute to magic-editor script * Fix timedcache issue * Add chunksProjectLoaded window * Use https magic-editor * add cache-id to chunks Co-authored-by: Francis Bulus <notchera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
3.1.31-canary.53.56d3822.0✨ Test out this PR locally via:
npm install editmode-react@3.1.31-canary.53.56d3822.0 # or yarn add editmode-react@3.1.31-canary.53.56d3822.0