Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

dt-benedict
Copy link
Collaborator

See commit message for details

@dynatrace-cla-bot
Copy link

dynatrace-cla-bot commented Aug 4, 2025

CLA assistant check
All committers have signed the CLA.

@dt-benedict
Copy link
Collaborator Author

CLA was signed ages ago :( I don't know why it doesn't pick it up

@MrManny
Copy link
Collaborator

MrManny commented Aug 5, 2025

What is the recommended way to test those changes? Do we perhaps have any incidents somewhere we can faux-troubleshoot?

@MrManny
Copy link
Collaborator

MrManny commented Aug 5, 2025

CLA was signed ages ago :( I don't know why it doesn't pick it up

Just a hunch, but maybe GitHub was unable to map the commit to your account?

@MrManny ➜ /workspaces/dynatrace-mcp (feature/standardize-agent-rules-naming) $ git log
commit ec55215db2fad77e5ead4c0c6bb2900d2e29fe53 (grafted, HEAD -> feature/standardize-agent-rules-naming, origin/feature/standardize-agent-rules-naming)
Author: Benedict Evert <benedictevert@dt-cvwjvf4lk9.clients.dynatrace.org>
Date:   Mon Aug 4 15:50:13 2025 +0200

    fix: apply Prettier formatting to root README.md
    
    - Fixed code style issues in the root README.md file
    - All files now pass Prettier formatting checks

@dt-benedict
Copy link
Collaborator Author

I signed the CLA last week again and now again, but it doesn't update it. I tried Github's instructions to link my account to the CLA somehow, but it doesn't work (as my account seems to be linked, but the CLA isn't?). Maybe I'll just re-commit?

@MrManny
Copy link
Collaborator

MrManny commented Aug 11, 2025

I signed the CLA last week again and now again, but it doesn't update it. I tried Github's instructions to link my account to the CLA somehow, but it doesn't work (as my account seems to be linked, but the CLA isn't?). Maybe I'll just re-commit?

Hmm. I am equally stumped. @christian-kreuzberger-dtx, do you have the option to merge despite the CLA check being weird?

@dt-benedict
Copy link
Collaborator Author

I opened a ticket/but with Github - although I signed the CLA multiple times now, it still shows at 'not signed'.

@dt-benedict dt-benedict force-pushed the feature/standardize-agent-rules-naming branch from ec55215 to 773a275 Compare August 13, 2025 11:57
Copy link
Collaborator

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Renamed files to follow 'Dynatrace' + camelCase convention:
  - incidentResponse.md → DynatraceIncidentResponse.md
  - INVESTIGATION_CHECKLIST.md → DynatraceInvestigationChecklist.md
  - dataInvestigation.md → DynatraceDataInvestigation.md

- Reorganized files into logical folder structure:
  - Created reference/ folder for technical documentation
  - Created workflows/ folder for analysis workflows
  - Created workflows/dataSourceGuides/ for data analysis guides

- Updated all internal links and cross-references to use new file names
- Updated README.md with new file structure and workflow mappings
- Fixed Mermaid diagram rendering issues
- Applied Prettier formatting to all markdown files

This creates a consistent, professional naming convention and
better organized documentation structure for the agent rules.
@christian-kreuzberger-dtx christian-kreuzberger-dtx force-pushed the feature/standardize-agent-rules-naming branch from 773a275 to e5adf31 Compare August 13, 2025 12:51
@christian-kreuzberger-dtx christian-kreuzberger-dtx merged commit be2a565 into main Aug 13, 2025
5 checks passed
@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the feature/standardize-agent-rules-naming branch August 13, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.