This repository was archived by the owner on Dec 20, 2024. It is now read-only.
bugfix: infinite loop in dfget/config/config.go#checkOutput #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnop
reviewed
May 2, 2020
| {clog: clog, url: "http://a.b.com", output: "/tmp/output", checkFunc: errortypes.IsNilError}, | ||
| {clog: clog, url: "http://a.b.com", output: "./root", checkFunc: errortypes.IsNilError}, | ||
| {clog: clog, url: "http://a.b.com", output: "/root", checkFunc: errortypes.IsInvalidValue}, | ||
| {clog: clog, url: "http://a.b.com", output: "/", checkFunc: errortypes.IsInvalidValue}, |
Contributor
There was a problem hiding this comment.
Please also update test cases for TestCheckOutput.
Signed-off-by: lowzj <zj3142063@gmail.com>
Contributor
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lowzj zj3142063@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes: #1320
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews