This repository was archived by the owner on Dec 20, 2024. It is now read-only.
add lru queue and mockFileServer #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56f4403 to
40b88a7
Compare
|
lgtm! |
2e13431 to
c4e6fb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
+ Coverage 48.96% 49.74% +0.78%
==========================================
Files 119 120 +1
Lines 7763 7936 +173
==========================================
+ Hits 3801 3948 +147
- Misses 3647 3665 +18
- Partials 315 323 +8
Continue to review full report at Codecov.
|
lowzj
reviewed
Apr 10, 2020
| data interface{} | ||
| } | ||
|
|
||
| type LRUQueue struct { |
Member
There was a problem hiding this comment.
add comments for export statement
allencloud
reviewed
Apr 10, 2020
dfget/core/helper/helper_test.go
Outdated
| return nil, fmt.Errorf("resp code %d", resp.StatusCode) | ||
| } | ||
|
|
||
| defer resp.Body.Close() |
Contributor
There was a problem hiding this comment.
I am afraid that you should move this defer in front of the 400 judgement
allencloud
reviewed
Apr 10, 2020
allencloud
reviewed
Apr 10, 2020
allencloud
reviewed
Apr 10, 2020
Signed-off-by: allen.wq <allen.wq@alipay.com>
c4e6fb0 to
b3222f5
Compare
lowzj
reviewed
Apr 13, 2020
|
|
||
| result[index] = item.Value.(*cQElementData).data | ||
| index++ | ||
| if index >= count { |
Member
There was a problem hiding this comment.
The index should be less the length of the list.
Contributor
Author
There was a problem hiding this comment.
if list is traversed to the end, the loop will be break by the case "item == nil"
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wq allen.wq@alipay.com
Ⅰ. Describe what this PR did
Add the lru queue and mock file server. It may be used in some test.
Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Already add it.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews