Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@zouy414
Copy link
Contributor

@zouy414 zouy414 commented Mar 24, 2020

Signed-off-by: ZouYu zouy.fnst@cn.fujitsu.com

Ⅰ. Describe what this PR did

add unit test for client/httputils.go

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Contributor

We found this is your first time to contribute to Dragonfly, @Hellcatlk
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
@pouchrobot pouchrobot added size/M and removed size/S labels Mar 24, 2020
@codecov-io
Copy link

Codecov Report

Merging #1258 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
- Coverage   48.51%   48.50%   -0.02%     
==========================================
  Files         121      121              
  Lines        7682     7682              
==========================================
- Hits         3727     3726       -1     
  Misses       3649     3649              
- Partials      306      307       +1     
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 21.91% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae7528...9abd23a. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit df222f9 into dragonflyoss:master Mar 24, 2020
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
…1258)

* feat: use a golang native file server to replace nginx

Signed-off-by: zzy987 <nevermind@sjtu.edu.cn>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.