Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e86252f

Browse filesBrowse files
authored
feat: Make Sphinx integration experimental publicly visible (bazel-contrib#1813)
With this commit the visibility settings are adjusted to use the Sphinx Integration from rules_python also in other (dependent) projects. Since the Sphinx integration is not yet stable, we denote in the documentation that this is done under the experimental API support. Meaning, breaking changes can occure at any point in time. See the discussion in bazel-contrib#1796
1 parent b5d32cd commit e86252f
Copy full SHA for e86252f

File tree

2 files changed

+6
-4
lines changed
Filter options

2 files changed

+6
-4
lines changed

‎sphinxdocs/private/BUILD.bazel

Copy file name to clipboardExpand all lines: sphinxdocs/private/BUILD.bazel
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ exports_files(
3434
"sphinx_build.py",
3535
"sphinx_server.py",
3636
],
37-
visibility = ["//:__subpackages__"],
37+
visibility = ["//visibility:public"],
3838
)
3939

4040
bzl_library(
@@ -70,22 +70,22 @@ py_binary(
7070
name = "inventory_builder",
7171
srcs = ["inventory_builder.py"],
7272
# Only public because it's an implicit attribute
73-
visibility = ["//:__subpackages__"],
73+
visibility = ["//visibility:public"],
7474
)
7575

7676
py_binary(
7777
name = "proto_to_markdown",
7878
srcs = ["proto_to_markdown.py"],
7979
# Only public because it's an implicit attribute
80-
visibility = ["//:__subpackages__"],
80+
visibility = ["//visibility:public"],
8181
deps = [":proto_to_markdown_lib"],
8282
)
8383

8484
py_library(
8585
name = "proto_to_markdown_lib",
8686
srcs = ["proto_to_markdown.py"],
8787
# Only public because it's an implicit attribute
88-
visibility = ["//:__subpackages__"],
88+
visibility = ["//visibility:public"],
8989
deps = [
9090
":stardoc_output_proto_py_pb2",
9191
],

‎sphinxdocs/sphinx.bzl

Copy file name to clipboardExpand all lines: sphinxdocs/sphinx.bzl
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ The general usage of the Sphinx rules requires two pieces:
2323
2424
Defining your own `sphinx-build` binary is necessary because Sphinx uses
2525
a plugin model to support extensibility.
26+
27+
The Sphinx integration is still experimental.
2628
"""
2729

2830
load(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.