NEW: Icons for Tab from Tab options#842
NEW: Icons for Tab from Tab options#842avmaksimov wants to merge 3 commits intodoublecmd:masterdoublecmd/doublecmd:masterfrom
Conversation
The tabs gets wider and nicer too. Also I suggest remove options tb_show_asterisk_for_locked because of now everybody can see status via icon. It's not text file manager anyway).
|
You took space away from users (2-3 symbols) and did it with no alternative, right? Also this feature depends on "Show icons for actions in menus". |
Is it a problem nowadays with resolution from 1300px? Or may be there is shortage of space because of many tabs open (at least more than 10)?
Yes. I recommend also rename this menu item and set on by default. |
|
Please make this an option, I prefer the existing style. |
Do you mean separate option or may be expand "Show icons for actions in menus" to "Show icons for tabs and actions in menus"? I think the better the last one. |
|
Also I propose to expand the option "Show locked tabs with an asterisk" to "Tabs headers style": "None", "Show locked tabs with an asterisk", "Show tabs icons" (the last one by default). I suggest not to add a new option but use existing as much as possible. |
Seperate option. Keep existing style as default.
Please do not assume, I still regularly use 800x600px. |
So do you think that somebody wants asterisk for locked and icons? OK. I'll wait for Alex2000's decision. |
|
I don't want to mix "Show icons for actions in menus" and show icons in tabs. It should be a two different options. So it is need to create a separate TImageList for tabs.
Maybe. Does anyone has other ideas? |
|
Maybe add group with Radio in the end of list, something like: and if the first option is selected, then block "Show locked tabs with an asterisk *" (for the last option, we do not need to correct the translation). |
I suggest this: In this way we do not need to correct the translation too. |
|
@avmaksimov, locked tabs will have their own icon, why do they need an asterisk? And if "Show title only" is selected, we won't have the "locked" marker. |
|
He suggest a three radio buttons, so only one can be selected. |
|
Yes. But not to use addition space I think now that combox is preffered option. |
|
I see three buttons, I don't understand how they should work if only one can be selected. What will the third button do?
? More logical:
|
I think it's understandable. The third button: title with asterisk do the title plus asterisk. And there will help for it. And also the space is not robber. Your suggestion needs more place. |
No :) The first button says "text and icon", the second buttons says "text only", but the third button says about some kind of asterisks only.
I know the measure ;) |
It makes the interface more saficticated. But I understand you and there is a new way from me). I think if we think more about interface so we don't think about saving the old phrase. Somebody needs to translate some new texts anyway.
Rather, it looks like double standards) |
More logical choice is a more understandable and friendly way. Maybe "Titles and icons" in this case? So that no one thinks that only icons will be displayed
Vote for me in 2024! :)))) |
I don't mind. So result is: |
|
https://doublecmd.h1n.ru/viewtopic.php?p=38819#p38819 TC can change a tab icon. I think using icons to mark some tabs can be useful too. |
I have answered. I suggest to make in the future). |
|
OK. And I should write it. I found out that the order is more than important in Tabs\Options (gDirTabOptions). I want to remove suboption for locked tabs and add new option "HeaderStyle" but removing is impossible.
I prefer the solution 2 because it's simplier now. But don't judge me strictly)) |
1. Separate option for tab icons. 2. It demanded some changes in Tab options dialog and I decided to separate by panels. Of course I can change it. The current look is here: https://skr.sh/sIiqDElbd2Z 3. Refactoring with UpdateActionIcons because I changed it before. I suggest to put ActAddToImageList to some module and may be create a new function to prepare Data for that func (TPicture, TImagelist, get and check properly path and so on). I thought about TPixManager or TIconTheme but this modules is very complicated for such jobs). 4. Also I keep TTabsOptions.tb_show_asterisk_for_locked because removing from it will shift all folowin options so it's needed to be converted to record one time. Thats why I have just added tb_show_icons and used two flags for one option.
|
Later I can changes Comboboxes to KASComboboxes to use AutoSize for them. |
|
And add Russian language. May be Moldovan too. If the rest of changes is OK. |
|
Why take options away from users? :) |
|
Are you sure someone use title without an asterisk? May be its you?)) I don't think so. |
|
Please keep existing options, it is not difficult, you risk upsetting somebody somewhere. |
OK. But for me it seems like you thinking somebody who may be doesn't exist). BTW. I can add later if somebody will ask. So... OK, again. I am waiting for author's answer about code and later I have to make proper TabOrder and localization (or may be he will want to do it by himself). |
Maybe you are correct. Maybe you are not. Either way, certainly add features, but try to avoid removing them. |
Do you have accurate statistics on the use of program options? Any statistics? :)
I did "will ask" :) I don't look like "somebody"? |
No. You can see that I wrote OK before.
You wrote about "users" before. Do you have such statistics? You didn't wrote that you need it. If you had wrote it before the discussion would stop many messages ago. |
|
Hmm... GitHub's date formatting is [strikethrough] and [strikethrough]. Was this post written before or after? |
I don't remember. May be the same moment)) |
@alexx2000, could you check and accept this PR please? |
|
Has this PR been updated? |
|
I planned to merge this PR. But macOS does not support icons in the tabs so this PR was frozen. |
The tabs gets wider and nicer too.
Also I suggest remove options tb_show_asterisk_for_locked because of now everybody can see status via icon. It's not text file manager anyway).