WIP: Add support for external viewer search#2258
Open
lars18th wants to merge 2 commits intodoublecmd:masterdoublecmd/doublecmd:masterfrom
lars18th:external-view-searchlars18th/doublecmd:external-view-searchCopy head branch name to clipboard
Open
WIP: Add support for external viewer search#2258lars18th wants to merge 2 commits intodoublecmd:masterdoublecmd/doublecmd:masterfrom lars18th:external-view-searchlars18th/doublecmd:external-view-searchCopy head branch name to clipboard
lars18th wants to merge 2 commits intodoublecmd:masterdoublecmd/doublecmd:masterfrom
lars18th:external-view-searchlars18th/doublecmd:external-view-searchCopy head branch name to clipboard
Conversation
Add parameters to call the external viewer with the search info. At time is implemented hardcoded for Universal Viewer parameters: /FText=String /FCase=0|1 /FWords=0|1 /FHex=0|1
Contributor
Author
|
This PR implements the request #1510 |
Contributor
Author
|
Hi @alexx2000 , I need your help to know the best strategy to add configurable support for this. Any idea?
|
Implemented in a dirty way: if the command contains "view" then add the search parameters.
Contributor
Author
|
Hi @alexx2000 , Please, do some comments. This works well on my system, but it is not completed. We need to provide a generic configuration to use it. And for this I need your feedback. |
Contributor
|
Hi, Yes, it should be a generic solution, something like you suggest in #1510. Like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameters to call the external viewer with the search info.
At time is implemented hardcoded for Universal Viewer parameters:
/FText=String
/FCase=0|1
/FWords=0|1
/FHex=0|1