Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ADD: MultiArc - update settings when defaults/platform changes#1940

Draft
j2969719 wants to merge 6 commits intodoublecmd:masterdoublecmd/doublecmd:masterfrom
j2969719:importj2969719/doublecmd:importCopy head branch name to clipboard
Draft

ADD: MultiArc - update settings when defaults/platform changes#1940
j2969719 wants to merge 6 commits intodoublecmd:masterdoublecmd/doublecmd:masterfrom
j2969719:importj2969719/doublecmd:importCopy head branch name to clipboard

Conversation

@j2969719
Copy link
Contributor

No description provided.

@ags1234
Copy link

ags1234 commented Oct 24, 2024

@j2969719 , what is this MultiArc that you keep updating files for?

@j2969719
Copy link
Contributor Author

@Skif-off
Copy link
Contributor

Small note: the help files mention the ability to import/export settings, but without much detail (I don't know what could be added there).

@j2969719 are you sure that forcing the AutoConfigure function is a good idea? If user is in the process of configuring several archivers, this can be inconvenient.

Perhaps it would be better to make changes in the multiarc.ini file as a separate PR?

@j2969719
Copy link
Contributor Author

autoconfig(search for an executable and disabling an addon if the executable is not found) will be forced when, for example, the config reports that it is saved under win, and the dc version is for linux, or when something was added/changed in default/multiarc.ini (in this case, existing default sections will be overwritten and backup copy will also be created).

people are already starting to ask why im so obsessed with this multiarc thing and updating the default config with this patch implies a version bump in umultiarc.pas anyway

@Skif-off
Copy link
Contributor

I meant that AutoConfigure will process ALL archivers, not just the one being added in this moment :)

@j2969719
Copy link
Contributor Author

welp thats kind of the point of it. i mean to enable those that are currently available and disable those that are not, since user could have installed/removed some archivers since the last autoconf, but didnt touch this settings in dc, or doesnt know anything about them at all. and for those who tinker with these settings there will be a backup copy

@ags1234
Copy link

ags1234 commented Oct 25, 2024

So this is all about the config stored in the file \settings\multiarc.ini?

@Skif-off
Copy link
Contributor

@j2969719, this is a global function, i.e. it will enable what I have disabled and disable what I have not finished with yet :)

@ags1234, yes, about configure external archivers.

@j2969719
Copy link
Contributor Author

j2969719 commented Oct 25, 2024

erm, do you assign executables at the very end?o_O version bump for multiarc will most likely occur even less often than for shortcuts.scf anyway

think this will be the least of the problems, because if eg some additional extensions were registered in 7z (ro), you will still have to merge the config anyway

@j2969719
Copy link
Contributor Author

can someone clone and look at the ace addon? github diff seems to show two spaces before n+, but on my end this line seems to be the same length as the current one o_O

@Skif-off
Copy link
Contributor

erm

This function does more than it is required to do in this case.

github diff seems to show two spaces before n+

Maybe there is a problem with fonts or rendering? I tried looking in GitExtensions, the line lengths are the same there.

@j2969719
Copy link
Contributor Author

j2969719 commented Oct 26, 2024

after #1669 i think on the contrary that autoconfigure is too little in this life because the user can install the archiver whenever he wants and ideally it should just work. while tinkers should bear their burden with dignity [and pain]

@j2969719 j2969719 marked this pull request as draft December 1, 2024 21:12
@j2969719 j2969719 force-pushed the import branch 2 times, most recently from 0a507bf to 1eb249b Compare February 20, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.