Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

UPD: Variables in file names for all internal commands#1848

Open
Skif-off wants to merge 1 commit intodoublecmd:masterdoublecmd/doublecmd:masterfrom
Skif-off:paths-in-commandsSkif-off/doublecmd:paths-in-commandsCopy head branch name to clipboard
Open

UPD: Variables in file names for all internal commands#1848
Skif-off wants to merge 1 commit intodoublecmd:masterdoublecmd/doublecmd:masterfrom
Skif-off:paths-in-commandsSkif-off/doublecmd:paths-in-commandsCopy head branch name to clipboard

Conversation

@Skif-off
Copy link
Contributor

@Skif-off Skif-off commented Sep 21, 2024 •
edited
Loading

cm_SaveTabs, cm_LoadTabs, cm_LoadList, cm_ChangeDir (legacy).

@Skif-off Skif-off force-pushed the paths-in-commands branch 7 times, most recently from be73ee5 to 21418ea Compare September 30, 2024 10:14
@Skif-off Skif-off force-pushed the paths-in-commands branch 7 times, most recently from 6c5c04c to 9fa7b53 Compare October 6, 2024 18:10
@Skif-off Skif-off force-pushed the paths-in-commands branch 4 times, most recently from 2af5e24 to d0ce976 Compare October 14, 2024 12:29
@Skif-off Skif-off force-pushed the paths-in-commands branch 4 times, most recently from 389f12e to 8d172ee Compare October 22, 2024 09:54
@Skif-off Skif-off force-pushed the paths-in-commands branch 3 times, most recently from acb3297 to da1019a Compare October 29, 2024 22:00
@Skif-off Skif-off force-pushed the paths-in-commands branch 5 times, most recently from ec90cb4 to a8eac97 Compare November 11, 2024 11:17
@Skif-off Skif-off force-pushed the paths-in-commands branch 3 times, most recently from b997ba2 to c370757 Compare February 2, 2025 03:48
@Skif-off Skif-off force-pushed the paths-in-commands branch 2 times, most recently from c64a6b4 to 45aaaa1 Compare February 4, 2025 12:10
@Skif-off
Copy link
Contributor Author

Skif-off commented Feb 4, 2025

@alexx2000
What do you think about these changes?

@alexx2000
Copy link
Contributor

alexx2000 commented Feb 8, 2025

I'm not sure yet that it is a good idea to use it everywhere. RemoveQuotation still can broke some file names, for example hello\ people. Maybe it is better to use here a simple function instead, which removes only a single or double quotes around file name.

@Skif-off
Copy link
Contributor Author

Skif-off commented Feb 8, 2025

I'm not sure yet that it is a good idea to use it everywhere.

I'm not sure too.
Currently, cm_SaveTabs, cm_LoadTabs and cm_LoadList cannot work with DC/environment variables (only full file names), so I just wanted the variables to work the same with all commands.

@Skif-off
Copy link
Contributor Author

Skif-off commented Feb 8, 2025

Maybe it is better to use here a simple function instead, which removes only a single or double quotes around file name.

Maybe, but what about backslash \ in Linux? PrepareParameter > ReplaceVarParams > QuoteStr > EscapeNoQuotes > EscapeString.
Should we always use %"0?

@alexx2000
Copy link
Contributor

alexx2000 commented Feb 9, 2025

Should we always use %"0?

Yes (for internal commands).

@Skif-off Skif-off force-pushed the paths-in-commands branch 2 times, most recently from 19c84aa to e510693 Compare March 4, 2025 19:16
@Skif-off Skif-off force-pushed the paths-in-commands branch 4 times, most recently from a160c43 to f621b1a Compare March 13, 2025 21:32
@Skif-off Skif-off force-pushed the paths-in-commands branch 2 times, most recently from c5beeb4 to a5e9ea1 Compare April 4, 2025 08:39
@Skif-off Skif-off force-pushed the paths-in-commands branch from a5e9ea1 to a1a2a34 Compare April 11, 2025 17:13
@Skif-off Skif-off force-pushed the paths-in-commands branch 2 times, most recently from f56f035 to 9c5dee6 Compare April 24, 2025 16:36
@Skif-off Skif-off force-pushed the paths-in-commands branch 3 times, most recently from d1b0c49 to e77ae8a Compare June 18, 2025 16:10
@Skif-off Skif-off force-pushed the paths-in-commands branch from e77ae8a to 7b49238 Compare June 25, 2025 14:43
@Skif-off Skif-off force-pushed the paths-in-commands branch 3 times, most recently from b4bf965 to 22f4129 Compare July 20, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skif-off @alexx2000
Morty Proxy This is a proxified and sanitized view of the page, visit original site.