Unified launch config #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #441 and #308 by creating an unified
launch.jsonfile whendotnet-scriptis installed as a global tool. Since installing as a global tool is the preferred way of installingdotnet-script, this should cover most of the cases.Note that this makes it possible to use the same
launch.jsonfile across operating systems as well as between versions ofdotnet-script.The solution is based on the comments by @ishearer and @natemcmaster in issue #308.
I have tested that it works on Mac, Linux and Windows.
Also fixed a bug that caused the
launch.jsonfile to be corrupted when the path tpdotnet-script.dllis updated. So this is now fixed for non global tool installs.See #441 (comment) for details on the file corruption.