Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

use <PackageLicenseExpression>MIT</PackageLicenseExpression> #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2018

Conversation

filipw
Copy link
Member

@filipw filipw commented Dec 18, 2018

immutable license embedded into the package instead of the license URL

@filipw filipw requested a review from seesharper December 18, 2018 13:36
<PackageProjectUrl>https://github.com/filipw/dotnet-script</PackageProjectUrl>
<PackageIconUrl>https://raw.githubusercontent.com/filipw/Strathweb.TypedRouting.AspNetCore/master/strathweb.png</PackageIconUrl>
<RepositoryUrl>https://github.com/filipw/dotnet-script.git</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<PackageTags>script;csx;csharp;roslyn;omnisharp</PackageTags>
<Version>0.8.0</Version>
<Version>0.9.0</Version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is by design, we forgot the bump in #402

Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was not aware of the PackageLicenseExpression 👍

Could it be that Chocolatey has problems with this

@seesharper
Copy link
Collaborator

LGTM 👍😻

@seesharper seesharper merged commit cf01f70 into master Dec 18, 2018
@filipw filipw deleted the feature/packagelicenseexpression branch December 18, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.