Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

init command - consider highlighting when .vscode/launch.json file overwritten and not updated #754

Copy link
Copy link
Open
@adamfk

Description

@adamfk
Issue body actions

Just a small suggestion.

When running dotnet-script init in a directory that already has a launch.json file with other configurations, I found it a bit surprising that it totally overwrote what I had there:

$ dotnet-script init
Creating VS Code launch configuration file
...'/home/afk/temp/.vscode/launch.json' already exists' [Skipping]
...Use global tool launch config [Updated]
<snip>

I had experience with the tool running as non-global where it used [Updated] to mean modified and not overwritten.

_scriptConsole.WriteHighlighted($"...Fixed path to dotnet-script: '{dotnetScriptPath}' [Updated]");

So maybe changing the wording to something like

 Creating VS Code launch configuration file
 ...'/home/afk/temp/.vscode/launch.json' already exists' [Skipping]
-...Use global tool launch config [Updated]
+...Use global tool launch config [File Overwritten]



One other related small suggestion: maybe only highlight messages like [Updated] instead of [Skipping]. Highlighting the skipping messages (which don't feel important) trains me to ignore the highlights.

So instead of:
image

It would print something like:
image

I'm happy to make a PR, but the changes are very small and might take more effort to review rather than implement.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.