Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[WIP] Allow focus on disabled controls #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

[WIP] Allow focus on disabled controls #7783

wants to merge 1 commit into from

Conversation

batzen
Copy link
Contributor

@batzen batzen commented Apr 29, 2023 •
edited by ghost
Loading

This is the first draft for #7749.

I also added new extensions to streamline focusable checks, but didn't use it yet.
Would be nice if I could get feedback on that one.

I tried to add the new property to IInputElement but the compat checks didn't pass and I found no way to make them pass.
Is there any documentation on how to add new interface members etc.?

Microsoft Reviewers: Open in CodeFlow

@batzen batzen requested a review from a team as a code owner April 29, 2023 08:51
@ghost ghost assigned batzen Apr 29, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 29, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf April 29, 2023 08:51
@ghost ghost added Community Contribution A label for all community Contributions 📭 waiting-author-feedback To request more information from author. labels Apr 29, 2023
@batzen batzen removed the 📭 waiting-author-feedback To request more information from author. label May 3, 2023
@miloush
Copy link
Contributor

miloush commented Jun 11, 2023

As for technical comments - why WhenNotEnabled rather than WhenDisabled? For the extensions I am not sure, first it's not great that they are properties exposed as methods and then CanFocus is bit ambiguous, is that keyboard focus or logical focus? Do you not need to check parents?

@batzen
Copy link
Contributor Author

batzen commented Nov 9, 2024

@harshit7962 any chance the WPF team could have a look at this?

@harshit7962
Copy link
Member

@batzen, we will include this in the next monthly test pass before proceeding with the review.

I tried to add the new property to IInputElement but the compat checks didn't pass and I found no way to make them pass.

Can you try using the the below build command, it should baseline the compat errors.
.\build.cmd -plat x64 /p:BaselineAllAPICompatError=true

@miloush
Copy link
Contributor

miloush commented Nov 11, 2024

Documented at https://github.com/dotnet/wpf/blob/main/Documentation/api-compat.md (you could have also manually edited the baseline file)

Test pass seems to be a bit premature, this should go through API review first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

At least 1 approving review is required to merge this pull request.

Assignees

@batzen batzen

Labels
API Change Community Contribution A label for all community Contributions 🚧 work in progress Included in test pass PR metadata: Label to tag PRs, to facilitate with triage Status:Cut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@batzen @miloush @harshit7962 @himgoyalmicro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.