Update C++ Tools to VS16.3 Preview 4 #2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not target 3.1 using libs that were built against 3.0. These libs are built against 3.1.
|
/cc @wtgodbe |
|
If this works we can close #2105 in favor of this |
wtgodbe
approved these changes
Oct 25, 2019
rladuca
approved these changes
Oct 25, 2019
|
I don't have write access to this repo to set the servicing-approved label 😄 Consider this one approved, as I'm virtual Steve at the moment. |
This was referenced Oct 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2114
There is a matching PR for dotnet-wpf-int#3879 that is needed along-with this change.
Description
This PR updates C++ tools used by WPF to VS 16.3 Preview 4 bits.
From #2105, we now know that C++ toolset containing libs that were built targeting 3.0 could not be used to build against 3.1 libs.
#2105 (comment)
The toolset in Dev 16.3+ were built against 3.1 libs.
Customer Impact
This blocks .NET Core 3.1 Preview 2 builds.
Risk
My recommendation is to merge this change now into release/3.1 branch to unblock preview builds, and continue with more testing as soon as a full SDK build is available.
Regression
The root cause for why the compiler team needed to rebuild their tools against 3.1 libs is unclear @tgani-msft mentioned that the compiler team has yet to root-cause it. We should try to understand this further IMO.