Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Address additional TitleBar corner case issues #13560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2025
Merged

Address additional TitleBar corner case issues #13560

merged 4 commits into from
Jun 6, 2025

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Jun 5, 2025 •
edited by dotnet-policy-service bot
Loading

We introduced a few new APIs around TitleBar control (independent of dark mode).

  • They have been put behind the DarkMode experimental flag, although they weren't really dark-mode related, but "just" controlling some TitleBar properties equally in Light- and in DarkMode.
  • When a Form needs to recreate a handle, they "lost" their settings, since we only applied the TitleBar settings initially.

Fixes #12991.
Fixes #12992.

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner June 5, 2025 16:52
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Jun 5, 2025
JeremyKuhne
JeremyKuhne requested changes Jun 5, 2025
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't clear from reading the comments what the exact ordering dependency is.

src/System.Windows.Forms/System/Windows/Forms/Form.cs Outdated Show resolved Hide resolved
@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Jun 5, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jun 5, 2025
JeremyKuhne
JeremyKuhne previously approved these changes Jun 6, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.59400%. Comparing base (4b461fd) to head (2bb00bc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #13560         +/-   ##
===================================================
- Coverage   76.60068%   76.59400%   -0.00669%     
===================================================
  Files           3230        3230                 
  Lines         639151      639161         +10     
  Branches       47295       47297          +2     
===================================================
- Hits          489594      489559         -35     
- Misses        145989      146019         +30     
- Partials        3568        3583         +15
Flag Coverage Δ
Debug 76.59400% <36.00000%> (-0.00669%) ⬇️
integration 18.79437% <36.00000%> (-0.00381%) ⬇️
production 50.99510% <36.00000%> (-0.01399%) ⬇️
test 97.40411% <ø> (ø)
unit 48.39395% <36.00000%> (+0.01156%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann merged commit 7a6ed89 into dotnet:main Jun 6, 2025
8 checks passed
@KlausLoeffelmann KlausLoeffelmann deleted the FixTitleBarIssues branch June 6, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shyam-Gupta Shyam-Gupta Shyam-Gupta approved these changes

@JeremyKuhne JeremyKuhne JeremyKuhne left review comments

Assignees

@KlausLoeffelmann KlausLoeffelmann

Labels
area-DarkMode Issues relating to Dark Mode feature
Projects
None yet
Milestone
No milestone
3 participants
@KlausLoeffelmann @JeremyKuhne @Shyam-Gupta
Morty Proxy This is a proxified and sanitized view of the page, visit original site.