Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

SimonZhao888
Copy link
Member

Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0 as it's the minimum supported by that assembly.

@SimonZhao888 SimonZhao888 requested review from MiYanni and joeloff June 27, 2025 02:36
@SimonZhao888 SimonZhao888 changed the title Update Microsoft.NET.Build.Tests that depend on System.ValueTuple to arget netstandard2.0 [release/9.0.1xx] Update Microsoft.NET.Build.Tests that depend on System.ValueTuple to arget netstandard2.0 Jun 27, 2025
@SimonZhao888 SimonZhao888 merged commit 525adf5 into release/9.0.1xx Jul 4, 2025
33 of 34 checks passed
@SimonZhao888 SimonZhao888 deleted the dev/simon/FixTestbugonRelease9.0.1 branch July 4, 2025 04:56
@SimonZhao888
Copy link
Member Author

/backport to release/8.0.1xx

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/16068238575

@SimonZhao888
Copy link
Member Author

/backport to release/8.0.3xx

Copy link
Contributor

github-actions bot commented Jul 4, 2025

@SimonZhao888 backporting to "release/8.0.1xx" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0
Using index info to reconstruct a base tree...
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopExeWithFSharp.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
A	test/Microsoft.NET.Build.Tests/GivenThereAreDefaultItems.cs
A	test/TestAssets/TestProjects/AppWithLibrary/TestLibrary/TestLibrary.csproj
A	test/TestAssets/TestProjects/AppWithLibraryFS/TestLibrary/TestLibrary.fsproj
A	test/TestAssets/TestProjects/AppWithLibraryVB/TestLibrary/TestLibrary.vbproj
Falling back to patching base and 3-way merge...
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThereAreDefaultItems.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/16068245868

Copy link
Contributor

github-actions bot commented Jul 4, 2025

@SimonZhao888 backporting to "release/8.0.3xx" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0
Using index info to reconstruct a base tree...
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopExeWithFSharp.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
A	test/Microsoft.NET.Build.Tests/GivenThereAreDefaultItems.cs
A	test/TestAssets/TestProjects/AppWithLibrary/TestLibrary/TestLibrary.csproj
A	test/TestAssets/TestProjects/AppWithLibraryFS/TestLibrary/TestLibrary.fsproj
A	test/TestAssets/TestProjects/AppWithLibraryVB/TestLibrary/TestLibrary.vbproj
Falling back to patching base and 3-way merge...
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThereAreDefaultItems.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@SimonZhao888
Copy link
Member Author

/backport to release/8.0.4xx

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/16068261715

Copy link
Contributor

github-actions bot commented Jul 4, 2025

@SimonZhao888 backporting to "release/8.0.4xx" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0
Using index info to reconstruct a base tree...
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopExeWithFSharp.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
A	test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
A	test/Microsoft.NET.Build.Tests/GivenThereAreDefaultItems.cs
A	test/TestAssets/TestProjects/AppWithLibrary/TestLibrary/TestLibrary.csproj
A	test/TestAssets/TestProjects/AppWithLibraryFS/TestLibrary/TestLibrary.fsproj
A	test/TestAssets/TestProjects/AppWithLibraryVB/TestLibrary/TestLibrary.vbproj
Falling back to patching base and 3-way merge...
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThereAreDefaultItems.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithVB.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithFSharp.cs
Auto-merging src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update Microsoft.NET.Build.Tests that depend on System.ValueTuple totarget netstandard2.0
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.