Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Stop Format redistributing MSBuild #49065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

Stop Format redistributing MSBuild #49065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb267f2
Update baseline MSBuild to patched version
rainersigwald May 19, 2025
612d805
Avoid redistributing MSBuild in format
rainersigwald May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
Additionally, set the MinimumVSVersion for the installer UI that's required for targeting NetCurrent -->
<MicrosoftBuildVersion>17.15.0-preview-25265-101</MicrosoftBuildVersion>
<MicrosoftBuildLocalizationVersion>17.15.0-preview-25265-101</MicrosoftBuildLocalizationVersion>
<MicrosoftBuildMinimumVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'">17.11.4</MicrosoftBuildMinimumVersion>
<MicrosoftBuildMinimumVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'">17.11.31</MicrosoftBuildMinimumVersion>
<MinimumVSVersion>17.13</MinimumVSVersion>
</PropertyGroup>
<PropertyGroup>
Expand Down
7 changes: 7 additions & 0 deletions 7 src/BuiltInTools/dotnet-format/dotnet-format.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@
<PackageReference Include="Microsoft.CodeAnalysis" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
<PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" />

<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" />
<!-- Suppress transitive dependencies of MSBuildWorkspace on MSBuild to avoid unnecessary copies -->
Copy link
Member

@jasonmalinowski jasonmalinowski May 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeRobich Do we have a tracking bug for your work which might make this unnecessary? Or at least FYI that we can potentially revert this soon enough.

<PackageReference Include="Microsoft.Build" ExcludeAssets="runtime" PrivateAssets="All" />
<PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="runtime" PrivateAssets="All" />
Copy link
Member

@jasonmalinowski jasonmalinowski May 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to break this:

sdk/src/BuiltInTools/dotnet-format/Workspaces/MSBuildWorkspaceLoader.cs

Lines 32 to 40 in 02ab00a

Build.Framework.ILogger? binlog = null;
if (binaryLogPath is not null)
{
binlog = new Build.Logging.BinaryLogger()
{
Parameters = binaryLogPath,
Verbosity = Build.Framework.LoggerVerbosity.Diagnostic,
};
}

If it's not for some reason, ExcludeAssets="compile;runtime" might be wise to ensure it's not being used by this code's compilation too.

<PackageReference Include="Microsoft.Build.Tasks.Core" ExcludeAssets="runtime" PrivateAssets="All" />
<PackageReference Include="Microsoft.Build.Utilities.Core" ExcludeAssets="runtime" PrivateAssets="All" />
<PackageReference Include="Microsoft.NET.StringTools" ExcludeAssets="runtime" PrivateAssets="All" />

<!-- Loaded dynamically -->
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Features" />
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.