Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix Orleans BankAccount Sample #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

krsion
Copy link

@krsion krsion commented Jun 7, 2025

Reverted usage of immutable balance, fixed Orleans Bank Account Transaction Sample.
Fixes #7021

Fixes Orleans BankAccount Sample dotnet#7021
@krsion krsion requested a review from a team as a code owner June 7, 2025 18:50
@krsion krsion changed the title Update AccountGrain.cs Fix Orleans BankAccount Sample Jun 7, 2025
@Rossimac
Copy link
Contributor

Rossimac commented Jun 8, 2025

I have an open PR here and I've fixed up the build issues today. Also, I changed a few things about the AccountGrain and the Balance class so that any changes are persisted after a Withdrawal. I ran into the same issues you're seeing with the balances not actually changing after a transaction :)

@BillWagner BillWagner requested a review from IEvangelist June 9, 2025 14:31
@gewarren gewarren requested a review from ReubenBond June 9, 2025 16:29
@ReubenBond
Copy link
Member

I (belatedly) merged @Rossimac's existing PR, so I'll close this PR since there are no additional changes necessary. Thank you for the PR, @krsion - please don't hesitate to open more to fix other issues you find

@ReubenBond ReubenBond closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orleans Bank Account/Transaction sample is broken
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.