[mono][interp] Testing tiering disabled #116070
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
This was referenced May 28, 2025
Open
3 tasks
8514e9a to
1fe2325
Compare
…during cprop The definition was not updated, leading to invalid optimizations later on.
Otherwise SSA dominance algorithms may fail to detect certain code flow and incorrectly manage phi nodes.
public bool M() {
bool ret = true;
try {
// throw NULL
} catch (NullReferenceException) {
goto Label;
}
ret = false;
Label:
return ret;
}
Without this fix, given the SSA cfg doesn't include EH bblocks, we would see the return opcode always reachable through the fallthrough from `ret = false`.
1fe2325 to
0f0f922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.