Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

josefpihrt
Copy link
Collaborator

fixes #1454

@josefpihrt josefpihrt self-assigned this May 8, 2024
@BenjaminBrienen
Copy link
Contributor

Would this fix this issue?

public void Setup(MarkdownPipelineBuilder pipeline)
{
	if (pipeline.BlockParsers.Find<HeadingBlockParser>() is HeadingBlockParser headingBlockParser)
	{
		// Install a hook on the HeadingBlockParser when a HeadingBlock is actually processed
		headingBlockParser.Closed -= HeadingBlockParser_Closed;
		headingBlockParser.Closed += HeadingBlockParser_Closed;
	}
	if (pipeline.BlockParsers.FindExact<ParagraphBlockParser>() is ParagraphBlockParser paragraphBlockParser) // Reduce 'if' nesting RCS1208
	{
		// Install a hook on the ParagraphBlockParser when a HeadingBlock is actually processed as a Setex heading
		paragraphBlockParser.Closed -= HeadingBlockParser_Closed;
		paragraphBlockParser.Closed += HeadingBlockParser_Closed;
	}
}

@josefpihrt
Copy link
Collaborator Author

I'm not sure that I'm following you.

@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented May 1, 2025

It suggests to invert that second if-block even though it wouldn't improve readability. This PR seems to add the concept of a "last if-block" and allows them.

@josefpihrt
Copy link
Collaborator Author

Tbh, I was working on this fix couple of months ago and the only thing I recall is that fix is almost impossible so I gave up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RCS1208 False-positive on flat if statement with multiple conditions

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.