Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[sample] Allow sample to run with different .net than on machine #29745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

rmarinho
Copy link
Member

Description of Change

Sometimes for example on net10.0 branch we want to run the sample with a particular .net version, by using the unpackaged type it allows it and we don t get an error saying the particular runtime is not installed on the machine.

@rmarinho rmarinho requested review from mattleibow and Copilot May 30, 2025 10:08
@rmarinho rmarinho requested a review from a team as a code owner May 30, 2025 10:08
@rmarinho rmarinho requested a review from tj-devel709 May 30, 2025 10:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables running the sample with an unpackaged .NET runtime by switching the launch profile to the Project command and configuring the project not to produce an MSIX package.

  • Updated launchSettings.json to use "commandName": "Project" instead of "MsixPackage".
  • Added <WindowsPackageType>None</WindowsPackageType> and removed the explicit removal of launchSettings.json in the .csproj.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Controls/samples/Controls.Sample/Properties/launchSettings.json Changed launch profile to use Project commandName.
src/Controls/samples/Controls.Sample/Maui.Controls.Sample.csproj Added WindowsPackageType=None and restored launchSettings.json.

@rmarinho rmarinho requested review from jsuarezruiz and removed request for tj-devel709 May 30, 2025 10:16
@rmarinho rmarinho merged commit 11ba4ed into main May 30, 2025
127 of 129 checks passed
@rmarinho rmarinho deleted the update-sample branch May 30, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.