[NET10] Enable Nullability on ShellPageRendererTracker #28441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullability on ShellPageRendererTracker and updates related iOS renderer classes to improve null-safety. Key changes involve enabling #nullable in ShellPageRendererTracker, updating property types and event handler signatures to account for nullability, and minor refactoring in UIContainerView.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/UIContainerView.cs | Minor refactoring in Disconnect with added null-safety handling. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs | Enabled #nullable, updated properties and event handler signatures, and adjusted toolbar/search handling for nullability. |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs:835
- Method name 'DettachSearchController' contains a typo; please consider renaming it to 'DetachSearchController'.
void DettachSearchController()
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
rmarinho
reviewed
Mar 26, 2025
| @@ -22,15 +19,25 @@ public class ShellPageRendererTracker : IShellPageRendererTracker, IFlyoutBehavi | ||
|
|
||
| public bool IsRootPage { get; set; } | ||
|
|
||
| #nullable disable |
There was a problem hiding this comment.
why are adding this here instead of fixing the all file?
There was a problem hiding this comment.
Because this properties are implementing the IShellPageRendererTracker interface. To add nullability here, we need to update the interface too.
|
/rebase |
|
All the iOS tests passed: |
rmarinho
requested changes
May 28, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
…geRendererTracker.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
…geRendererTracker.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
…geRendererTracker.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
…geRendererTracker.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
…geRendererTracker.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
…geRendererTracker.cs Co-authored-by: Rui Marinho <me@ruimarinho.net>
Have done the changes, could you review it again? |
|
/rebase |
rmarinho
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Enable Nullability on
ShellPageRendererTracker.Issues Fixed
Fixes #27162