[iOS] Shell Flyout Header and Footer not respecting safe area in landscape mode #28379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @praveenkumarkarunanithi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Mar 14, 2025
| #elif MACCATALYST | ||
| App.EnterFullScreen(); | ||
| #endif | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots, already available in the latest build.
Example, Android:
Could you commit the images?
There was a problem hiding this comment.
Snapshot different than baseline: FlyoutShouldRespectSafeAreaInLandscape.png (size differs - baseline is 2556x1178 pixels, actual is 2436x974 pixels)
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
0c1c412 to
342aff7
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The root cause of the issue (extra white space appearing on the left side of the Shell Flyout header and footer in landscape mode on iOS) is that the left safe area inset is implicitly applied to the Shell Flyout content (
UITableView) by the system'sUITableViewController. Specifically, the UITableViewController automatically respects the safe area insets provided by the system, causing the content to shift rightward in landscape mode. However, the Shell Flyout header and footer views are managed separately byShellFlyoutLayoutManagerandShellFlyoutContentRenderer, and these views were not explicitly respecting the left safe area inset. As a result, the header and footer did not align correctly with the content, causing visual inconsistencies and unwanted white space.Description of Change
ShellFlyoutLayoutManager.cs:Updated the
LayoutHeaderandLayoutContentmethods to explicitly apply the left safe area inset (UIApplication.SharedApplication.GetSafeAreaInsetsForWindow().Left) to the header and content views. This ensures the header view aligns correctly with the content view, respecting the left safe area inset.ShellFlyoutContentRenderer.cs:Modified the
UpdateFooterPosition()method to explicitly apply the left safe area inset to the footer view. This ensures the footer aligns correctly with the content and header views.Made
ShouldHonorSafeAreamethod internal:Changed the accessibility of the
ShouldHonorSafeAreamethod inShellFlyoutLayoutManagerfrom private to internal, allowing it to be accessed fromShellFlyoutContentRendererto determine if the footer should respect or ignore safe area insets.Issues Fixed
Fixes #20131
Tested the behaviour in the following platforms
Screenshots