Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update StreamReader.xml #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

Conversation

colejohnson66
Copy link
Contributor

Summary

The documentation for IOException on StreamReader.Read(Span<char>) is not just wrong, but hides the actual reason an IOException can occur.

Also unified the text for all relevant IOException reasons.

Fixes #9798.

Fixes dotnet#9798; Wrong documentation on `Read(Span<char>)` for `IOException`.
@colejohnson66 colejohnson66 requested a review from a team as a code owner April 18, 2024 12:10
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 18, 2024
@ghost ghost added the area-System.IO label Apr 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io

This comment was marked as outdated.

@colejohnson66 colejohnson66 marked this pull request as draft September 9, 2024 00:48
@colejohnson66 colejohnson66 marked this pull request as ready for review September 9, 2024 00:48
Copy link

Learn Build status updates of commit 785dee8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/StreamReader.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringReader.Read(Span<Char>) does not actually throw IOException
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.