Add RFC 3986 non-compliance message to Query and Fragment #8985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Learn Build status updates of commit 614661e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
MihaZupan
requested changes
May 9, 2023
There was a problem hiding this comment.
As discussed in dotnet/runtime#84955, we feel that including this information in the summary would lead to more confusion, but we would accept a clarification in the remarks section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds additional context to the developer to be aware that these properties do not comply with the industry standard RFC 3986.
More information here: dotnet/runtime#84955