Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update ILogger documentation to clarify formatter behavior when using extension methods #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

enioluwas
Copy link
Contributor

Summary

As described in the issue, the ILogger extension methods defined in LoggerExtensions pass in a formatter that ignores the exception parameter passed in. This is being made clear so that developers do not assume otherwise.

Fixes #10318

@enioluwas enioluwas requested a review from a team as a code owner August 30, 2024 20:47
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 30, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-logging

Copy link

Learn Build status updates of commit dd3cbfb:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Logging/ILogger.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

xml/Microsoft.Extensions.Logging/ILogger.xml Outdated Show resolved Hide resolved
xml/Microsoft.Extensions.Logging/ILogger.xml Outdated Show resolved Hide resolved
Copy link

Learn Build status updates of commit 21a34ed:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/Microsoft.Extensions.Logging/ILogger.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/Microsoft.Extensions.Logging/ILogger.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: '"' is an unexpected token. The expected token is '='. Line 146, position 467.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(String expectedToken1, String expectedToken2)
   at System.Xml.XmlTextReaderImpl.ParseAttributes()
   at System.Xml.XmlTextReaderImpl.ParseElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r, LoadOptions o)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@tarekgh tarekgh requested a review from gewarren August 30, 2024 22:14
Copy link

Learn Build status updates of commit f490ee1:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Logging/ILogger.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@tarekgh tarekgh merged commit 212eb2d into dotnet:main Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.Logging.LoggerExtensions.LogError does not log provided exception.
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.