-
Notifications
You must be signed in to change notification settings - Fork 176
Fixes required for stable preview builds + some improvements #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes required for stable preview builds + some improvements #575
Conversation
....Configuration.UserSecrets/tests/Microsoft.Extensions.Configuration.UserSecrets.Tests.csproj
Outdated
Show resolved
Hide resolved
c4026b6
to
5f3e50d
Compare
Do you have a validation run of the full unified build pipeline (with later build passes)? |
Also, I think it would be useful to have a parameter to the official pipeline to select building with stabilized versions so we can easily validate (in the same way we can turn signing and ibc on and off). |
I think the way we'll probably ship is with the "stable" switch checked in. But a parameter that sets the value if not specific seems like a good idea.
Good point. I'll get this done after I resolve the SB issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions.props changes don't sync back so blocking this until the individual repos changes flowed in.
Fine by me. I'll iterate on the stable switch and source build errors. |
Looks like the windowsdesktop, winforms and wpf ones are already in. Do you plan to submit a PR to dotnet/sdk for the sdk ones? |
SDK: dotnet/sdk#49017 |
Diagnostics: dotnet/diagnostics#5486 |
513fe33
to
d2e21a4
Compare
Rebased this back onto main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runtime changes LGTM
…m/mmitche/dotnet into attempt-stabilize-package-version
This reverts commit 6c1267b.
Waiting on any last feedback here: dotnet/fsharp#18701 |
FSharp is in. Now to get that forward flow and then merge in here. Then this PR should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does command-line-api.proj need AllowDotNetFinalVersionKindOverride
as well?
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sets of fixes required for creating stable preview builds.