Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixes required for stable preview builds + some improvements #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
Jun 26, 2025

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 15, 2025

Sets of fixes required for creating stable preview builds.

  • Use the ref pack versions in place of the x64 runtime version
  • Use the platform version for places that should use non-stable versions
  • Fix some places that were using the wrong version type
  • Remove all places that were using arch specific versions
  • Remove all the special property setups for the arch specific versions.

@mmitche mmitche requested review from a team as code owners May 15, 2025 21:58
@mmitche mmitche force-pushed the attempt-stabilize-package-version branch from c4026b6 to 5f3e50d Compare May 15, 2025 22:11
src/diagnostics/eng/Versions.props Outdated Show resolved Hide resolved
@jkoritzinsky
Copy link
Member

Do you have a validation run of the full unified build pipeline (with later build passes)?

@jkoritzinsky
Copy link
Member

Also, I think it would be useful to have a parameter to the official pipeline to select building with stabilized versions so we can easily validate (in the same way we can turn signing and ibc on and off).

@mmitche
Copy link
Member Author

mmitche commented May 15, 2025

Also, I think it would be useful to have a parameter to the official pipeline to select building with stabilized versions so we can easily validate (in the same way we can turn signing and ibc on and off).

I think the way we'll probably ship is with the "stable" switch checked in. But a parameter that sets the value if not specific seems like a good idea.

Do you have a validation run of the full unified build pipeline (with later build passes)?

Good point. I'll get this done after I resolve the SB issue.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions.props changes don't sync back so blocking this until the individual repos changes flowed in.

@mmitche
Copy link
Member Author

mmitche commented May 16, 2025

Versions.props changes don't sync back so blocking this until the individual repos changes flowed in.

Fine by me. I'll iterate on the stable switch and source build errors.

@ViktorHofer
Copy link
Member

Looks like the windowsdesktop, winforms and wpf ones are already in. Do you plan to submit a PR to dotnet/sdk for the sdk ones?

@mmitche
Copy link
Member Author

mmitche commented May 16, 2025

SDK: dotnet/sdk#49017

@mmitche
Copy link
Member Author

mmitche commented May 16, 2025

Diagnostics: dotnet/diagnostics#5486

@mmitche mmitche changed the base branch from main to release/10.0.1xx-preview5 May 21, 2025 19:27
@mmitche mmitche changed the base branch from release/10.0.1xx-preview5 to main May 21, 2025 23:55
@mmitche mmitche changed the base branch from main to release/10.0.1xx-preview5 May 21, 2025 23:56
@mmitche
Copy link
Member Author

mmitche commented May 23, 2025

@mmitche
Copy link
Member Author

mmitche commented May 27, 2025

@mmitche
Copy link
Member Author

mmitche commented May 27, 2025

@mmitche mmitche changed the base branch from release/10.0.1xx-preview5 to main May 30, 2025 17:43
@mmitche mmitche requested a review from premun as a code owner May 30, 2025 17:43
@mmitche mmitche force-pushed the attempt-stabilize-package-version branch from 513fe33 to d2e21a4 Compare May 30, 2025 17:43
@mmitche
Copy link
Member Author

mmitche commented May 30, 2025

Rebased this back onto main

build.sh Show resolved Hide resolved
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime changes LGTM

@mmitche
Copy link
Member Author

mmitche commented Jun 18, 2025

dotnet/sdk#49463

@mmitche
Copy link
Member Author

mmitche commented Jun 20, 2025

Waiting on any last feedback here: dotnet/fsharp#18701

@mmitche
Copy link
Member Author

mmitche commented Jun 24, 2025

FSharp is in. Now to get that forward flow and then merge in here. Then this PR should be good to go.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does command-line-api.proj need AllowDotNetFinalVersionKindOverride as well?

repo-projects/windowsdesktop.proj Show resolved Hide resolved
@mmitche mmitche merged commit 032c08c into dotnet:main Jun 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.