Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[release/10.0.1xx-preview6] Source code updates from dotnet/winforms #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2025
Merged

[release/10.0.1xx-preview6] Source code updates from dotnet/winforms #1217

merged 6 commits into from
Jun 19, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 17, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/winforms

@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Important

There are conflicts with the release/10.0.1xx-preview6 branch in this PR. Apart from conflicts in the source files, this means there are unresolved conflicts in the codeflow metadata file src/source-manifest.json.
When resolving these, please use the (incoming/ours) version from the PR branch. The correct content should be this:

{
  "packageVersion": "10.0.0-preview.6.25315.6",
  "barId": 271868,
  "path": "winforms",
  "remoteUri": "https://github.com/dotnet/winforms",
  "commitSha": "a64fee10485a618849e0bf5418ae2f76cc15ed66"
}

In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance.

@mmitche
Merge branch 'release/10.0.1xx-preview6' into darc-release/10.0.1xx-p…
af77bbe 
…review6-e18663c0-b7ee-406c-8bc7-01a7469ac6a1
@mmitche mmitche enabled auto-merge (squash) June 17, 2025 23:45
@akoeplinger
Copy link
Member

@LeafShi1 can you please take a look at the failures here?

  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(19,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.Default = 0 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(24,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.DoNotRound = 1 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(29,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.Round = 2 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(34,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.RoundSmall = 3 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(14,13): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2690,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormBorderColorChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2702,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormCaptionBackColorChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2714,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormCaptionTextColorChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2726,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormCornerPreferenceChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2303,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormCornerPreferenceChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2385,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormBorderColorChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2448,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormCaptionBackColorChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2511,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormCaptionTextColorChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]

@mmitche
Copy link
Member

mmitche commented Jun 18, 2025

@LeafShi1 can you please take a look at the failures here?

  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(19,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.Default = 0 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(24,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.DoNotRound = 1 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(29,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.Round = 2 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(34,5): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference.RoundSmall = 3 -> System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\FormCornerPreference.cs(14,13): error RS0016: Symbol '[WFO5001]System.Windows.Forms.FormCornerPreference' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2690,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormBorderColorChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2702,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormCaptionBackColorChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2714,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormCaptionTextColorChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2726,32): error RS0016: Symbol '[WFO5001]System.Windows.Forms.Form.FormCornerPreferenceChanged -> System.EventHandler?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2303,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormCornerPreferenceChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2385,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormBorderColorChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2448,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormCaptionBackColorChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]
  D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System\Windows\Forms\Form.cs(2511,28): error RS0016: Symbol '[WFO5001]virtual System.Windows.Forms.Form.OnFormCaptionTextColorChanged(System.EventArgs! e) -> void' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [D:\a\_work\1\s\src\winforms\src\System.Windows.Forms\System.Windows.Forms.csproj]

There was a conflict involving the unshipped public APIs. I took the incoming (winforms has an empty file)

@mmitche mmitche merged commit 56aa4e0 into release/10.0.1xx-preview6 Jun 19, 2025
14 of 15 checks passed
@mmitche mmitche deleted the darc-release/10.0.1xx-preview6-e18663c0-b7ee-406c-8bc7-01a7469ac6a1 branch June 19, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoeplinger @mmitche
Morty Proxy This is a proxified and sanitized view of the page, visit original site.