Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move from FluentAssertions to AwesomeAssertions #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

artl93
Copy link
Member

@artl93 artl93 commented Apr 22, 2025

Fixes #2545

Moves from FluentAssertions 6.x to AwesomeAssertions 8.x.
Addressed subtle differences in API.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @artl93 !

@@ -311,6 +311,7 @@ public void When_a_subcommand_has_been_specified_then_its_sibling_commands_will_
var result = rootCommand.Parse("cherry ", simpleConfig);

result.GetCompletions()
.Select(item => item.Label)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I wonder how it worked so far with FluentAssertions (using .ToString implicitly?)

@adamsitnik adamsitnik merged commit e8282e7 into dotnet:main Apr 22, 2025
10 checks passed
@artl93 artl93 deleted the artl93/awesomeassertions branch May 19, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving away from FluentAssertions
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.