Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jul 23, 2025

Updates version branding in eng/Versions.props to rc1

@Copilot Copilot AI review requested due to automatic review settings July 23, 2025 22:45
@mmitche mmitche requested review from a team and wtgodbe as code owners July 23, 2025 22:45
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version branding from preview to release candidate (rc1) for ASP.NET Core version 10.0.0. The changes prepare the codebase for a release candidate milestone by updating version iteration and labels.

Key changes:

  • Updates pre-release version iteration from 7 to 1
  • Changes pre-release version label from "preview" to "rc"

<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionLabel>rc</PreReleaseVersionLabel>
<PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
Copy link

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PreReleaseBrandingLabel still contains 'Preview' but should be updated to 'RC' to match the change from preview to rc branding. This will result in inconsistent version branding where the label says 'rc' but the branding says 'Preview 1'.

Suggested change
<PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
<PreReleaseBrandingLabel>RC $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>

Copilot uses AI. Check for mistakes.

Positive FeedbackNegative Feedback
@wtgodbe wtgodbe added this to the 10.0-rc1 milestone Jul 23, 2025
@wtgodbe wtgodbe merged commit c56ce2f into main Jul 24, 2025
31 checks passed
@wtgodbe wtgodbe deleted the main-rc1-branding-update branch July 24, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.