Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Pad them digits#91

Closed
dannguyen wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom
dannguyen:patch-1dannguyen/docsplit:patch-1Copy head branch name to clipboard
Closed

Pad them digits#91
dannguyen wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom
dannguyen:patch-1dannguyen/docsplit:patch-1Copy head branch name to clipboard

Conversation

@dannguyen
Copy link

Calculates the base 10 log of the page count and pads the filenames' page numbers appropriately.

Calculates the base 10 log of the page count and pads the filenames' page numbers appropriately.
@knowtheory
Copy link
Member

oop. need that to be optional. DocumentCloud's viewer for instance depends on a particular output format... which happens to coincide w/ how Docsplit spits out pages (w/o padding).

@dannguyen
Copy link
Author

But this is a critical issue for users with OCD. I'm all for backwards-compatibility, but the DC viewer seems like an edge case.

@jashkenas
Copy link
Member

Padding is nasty. Better to hack your filesystem to properly sort numbers in natural order, no? ;)

@dannguyen
Copy link
Author

Actually, when I was about to take a screenshot to submit with my pull request, I noticed that that OSX Mountain Lion does sort non-padded numbered files in numerical order, though I had already written the pull request and needed to submit something in order to keep my Github commit-streak alive. But think of the Windows users.

@jashkenas
Copy link
Member

The Windows users appear to be covered: http://support.microsoft.com/kb/319827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.