Fix escaping when extracting text using OCR#149
Open
floehopper wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom
freerange:fix-escaping-when-extracting-text-using-ocrfreerange/docsplit:fix-escaping-when-extracting-text-using-ocrCopy head branch name to clipboard
Open
Fix escaping when extracting text using OCR#149floehopper wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom freerange:fix-escaping-when-extracting-text-using-ocrfreerange/docsplit:fix-escaping-when-extracting-text-using-ocrCopy head branch name to clipboard
floehopper wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom
freerange:fix-escaping-when-extracting-text-using-ocrfreerange/docsplit:fix-escaping-when-extracting-text-using-ocrCopy head branch name to clipboard
Conversation
Previously the output filename passed to the tesseract command was not
shell-escaped. This meant that the filename was truncated and did not
match the filename expected by Docsplit::TextExtractor#clean_text
resulting in the following exception:
Errno::ENOENT: No such file or directory @ rb_sysopen - test/output/PDF file with spaces 'single' and "double quotes".txt
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:90:in `initialize'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:90:in `open'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:90:in `clean_text'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:80:in `extract_from_ocr'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:36:in `block in extract'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:32:in `each'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit/text_extractor.rb:32:in `extract'
/Users/jamesmead/Code/freerange/docsplit/lib/docsplit.rb:52:in `extract_text'
test/unit/test_extract_text.rb:58:in `test_name_escaping_while_extracting_text_using_ocr'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the output filename passed to the
tesseractcommand was not shell-escaped. This meant that the filename was truncated and did not match the filename expected byDocsplit::TextExtractor#clean_textresulting in the following exception: