Fix page parsing for command line usage#131
Open
xavriley wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom
xavriley:fix_page_params_in_clixavriley/docsplit:fix_page_params_in_cliCopy head branch name to clipboard
Open
Fix page parsing for command line usage#131xavriley wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom xavriley:fix_page_params_in_clixavriley/docsplit:fix_page_params_in_cliCopy head branch name to clipboard
xavriley wants to merge 1 commit intodocumentcloud:masterdocumentcloud/docsplit:masterfrom
xavriley:fix_page_params_in_clixavriley/docsplit:fix_page_params_in_cliCopy head branch name to clipboard
Conversation
This fixes the `--page` argument to work as described in the documentation when using docsplit from the command line. Users can now specify page ranges `5-15`, comma separated lists `1,5,7`, single pages `3` or combinations of these e.g. `3-5,7,8,12-15` The options parser was previously passing through a String where an Array was expected internally. This was not an issue when using the gem directly from Ruby, only when using the command line. This includes a command_line unit test to exercise the new page number parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
--pageargument to work as described in thedocumentation when using docsplit from the command line. Users can now
specify page ranges
5-15, comma separated lists1,5,7, single pages3or combinations of these e.g.3-5,7,8,12-15The options parser was previously passing through a String where an
Array was expected internally. This was not an issue when using the gem directly
from Ruby, only when using the command line.
This includes a command_line unit test to exercise the new page number parser.