Add support for schema assets filter option #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case of documentation: https://github.com/doctrine/DoctrineORMModule/blob/5.1.x/docs/en/configuration.rst |
|
I've added a unit test and documentation example! |
SenseException
approved these changes
Feb 3, 2022
|
@villermen Could you please rebase your changes on the latest |
f48fa01 to
17d32e0
Compare
|
@driehle Done! |
driehle
approved these changes
Feb 5, 2022
|
Thank you for your time and contribution, @villermen! It will probably take a few days for the release of 5.1.0 though, but you can give 5.1.x-dev a try if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$filterSchemaAssetsExpressionwas deprecated, but its$schemaAssetsFiltercallback replacement hasn't been implemented in doctrine-orm-module yet. This PR tries to correct that by defining the option onConfiguration.If there is any additional documentation/testing needed just point me in the right direction and I'll get that sorted!